feat: avoid "string" as parameter name to improve readability #4146
+9
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
|
Hi @mikeloguay ! Thanks for pointing this out. I agree, we can make a change here. I'd like to suggest |
|
Hi @sarahhaggarty, no problem for the delay. I was following the tour and just thought this was a bit confusing. OK about the rename to |
sarahhaggarty
approved these changes
May 28, 2024
|
Great! Thanks for your contribution @mikeloguay ! |
To you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In general, I think it is a bad idea to use name parameters with the same name of its type. I am coming from C#, and there both
stringandStringare the reserved words for the type name. It could be confusing and easily avoided usingmessage,word, or something else instead.